-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DataTable): add position relative to prevent jumping #9418
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 9d3dc3c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610e39fc41d32e0008ccb92e 😎 Browse the preview: https://deploy-preview-9418--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 9d3dc3c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610e39fce5a91a000826ab13 😎 Browse the preview: https://deploy-preview-9418--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 44d604a 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610abc3c7a53210009be8b4d 😎 Browse the preview: https://deploy-preview-9418--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 9d3dc3c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610e39fca4c0740008f24ddd 😎 Browse the preview: https://deploy-preview-9418--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! 🏄🏾
Closes #9403
Adds
position: relative
to prevent jumping when a checkbox is checked in a scrollable div.Changelog
New
position: relative
to data tableTesting / Reviewing
Check out https://codesandbox.io/s/adoring-sound-cvryv?file=/index.html and add
position: relative
to.bx--data-table-container
. Scroll down and check a checkbox, the page shouldn't jump.Ensure all data table variants remain unchanged.