Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataTable): add position relative to prevent jumping #9418

Merged
merged 5 commits into from
Aug 7, 2021

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Aug 4, 2021

Closes #9403

Adds position: relative to prevent jumping when a checkbox is checked in a scrollable div.

Changelog

New

  • position: relative to data table

Testing / Reviewing

Check out https://codesandbox.io/s/adoring-sound-cvryv?file=/index.html and add position: relative to .bx--data-table-container. Scroll down and check a checkbox, the page shouldn't jump.

Ensure all data table variants remain unchanged.

@tw15egan tw15egan requested a review from a team as a code owner August 4, 2021 16:11
@netlify
Copy link

netlify bot commented Aug 4, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 9d3dc3c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610e39fc41d32e0008ccb92e

😎 Browse the preview: https://deploy-preview-9418--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 4, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 9d3dc3c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610e39fce5a91a000826ab13

😎 Browse the preview: https://deploy-preview-9418--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 4, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 44d604a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610abc3c7a53210009be8b4d

😎 Browse the preview: https://deploy-preview-9418--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Aug 4, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 9d3dc3c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610e39fca4c0740008f24ddd

😎 Browse the preview: https://deploy-preview-9418--carbon-components-react.netlify.app

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! 🏄🏾

@kodiakhq kodiakhq bot merged commit f7573bd into carbon-design-system:main Aug 7, 2021
This was referenced Aug 17, 2021
@tw15egan tw15egan deleted the table-fix branch March 3, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking table checkbox scrolls everything out of viewport
3 participants