Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Combobox): add event propagation to mouse down #9402

Merged
merged 11 commits into from
Sep 2, 2021
Merged

fix(Combobox): add event propagation to mouse down #9402

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b31b234
fix(Combobox): add event propagation to mouse down
dakahn Aug 3, 2021
606c61b
fix(combobox): ignore downshift behavior for chevron click when listb…
tay1orjones Aug 26, 2021
2b5ac92
Merge branch 'main' into 9073-add-combobox-eventpropagation
tay1orjones Aug 26, 2021
6f62e44
docs(combobox): add multiple instances story
tay1orjones Aug 26, 2021
89b58c4
Merge branch '9073-add-combobox-eventpropagation' of https://github.c…
tay1orjones Aug 26, 2021
32ed27f
test(combobox): multiple instances should only render one listbox at …
tay1orjones Aug 26, 2021
54af89a
chore: remove unecessary id value
tay1orjones Aug 26, 2021
9f7d2a9
test(combobox): add query abstraction for readability
tay1orjones Aug 26, 2021
f2a0ed5
Merge branch 'main' into 9073-add-combobox-eventpropagation
tay1orjones Aug 30, 2021
516cd24
fix(Combobox): remove test story
tw15egan Sep 2, 2021
405c5d2
Merge branch 'main' into 9073-add-combobox-eventpropagation
kodiakhq[bot] Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/react/src/components/ComboBox/ComboBox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,10 @@ const ComboBox = React.forwardRef((props, ref) => {
// stop the event from propagating to prevent this. This allows the
// toggleMenu behavior for the toggleButton to correctly open and
// close the menu.
onMouseUp(event) {
event.stopPropagation();
onMouseUp() {
sstrubberg marked this conversation as resolved.
Show resolved Hide resolved
if (textInput?.current) {
textInput.current.focus();
}
},
});
const inputProps = getInputProps({
Expand Down