Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add grid and codesnippet visual regression tests #9365

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Jul 29, 2021

Closes #9267
Closes #9278

Adds some simple visual regression tests for CodeSnippet and the new CSS Grid implementation

Changelog

New

  • grid: visual regression tests
  • codesnippet: visual regression tests

Testing / Reviewing

The percy status check - click "details" link - should show new snapshots for Grid and CodeSnippet, though I'm not sure if this will require explicit "Approval" in the tool because these are new snapshots.

@tay1orjones tay1orjones requested a review from a team as a code owner July 29, 2021 19:35
@netlify
Copy link

netlify bot commented Jul 29, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 0b9346b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610aa2b535b0690007b9d2c7

😎 Browse the preview: https://deploy-preview-9365--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 29, 2021

❌ Deploy Preview for carbon-elements failed.

🔨 Explore the source changes: 0b9346b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610aa2b5e076ec0007c242dd

@netlify
Copy link

netlify bot commented Jul 29, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 0b9346b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610aa2b5efd4920007359bf3

😎 Browse the preview: https://deploy-preview-9365--carbon-components-react.netlify.app

@sstrubberg sstrubberg enabled auto-merge (squash) August 4, 2021 14:22
@sstrubberg sstrubberg merged commit 98555dc into carbon-design-system:main Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VRT for Grid Add VRT for CodeSnippet
3 participants