fix(TooltipDefinition): render span in component
#8910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 8763d77 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60c9018f4727e30008b3c8bc 😎 Browse the preview: https://deploy-preview-8910--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 8763d77 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60c9018f3250720008780b09 😎 Browse the preview: https://deploy-preview-8910--carbon-components-react.netlify.app/iframe |
tay1orjones
approved these changes
Jun 15, 2021
andreancardona
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
andreancardona
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8884
This PR updates
TooltipDefinitionto renderspanrather thandivto avoid DOM nesting warnings, especially since definition tooltips will commonly be used inline with paragraph textTesting / Reviewing
Verify that no DOM nesting warnings are emitted when using
DefinitionTooltipinptags