Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popover): updating popover alignments #8876

Merged
merged 2 commits into from
Jun 11, 2021
Merged

feat(popover): updating popover alignments #8876

merged 2 commits into from
Jun 11, 2021

Conversation

andreancardona
Copy link
Contributor

Closes #8873

This feature updates the alignments on Popover to be similar to that of tooltip / aligned to how a reader would view the popover placement

Testing

  • Make sure all of the alignments follow visual flow ex: bottom the text box moves below the caret
  • ex: right the popover moves all the way to the right of the screen

@andreancardona andreancardona requested a review from a team as a code owner June 10, 2021 00:42
@netlify
Copy link

netlify bot commented Jun 10, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: c1f1b20

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60c3767839f10c0007fe1b9a

😎 Browse the preview: https://deploy-preview-8876--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 10, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: c1f1b20

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60c376784df98b000814a3e6

😎 Browse the preview: https://deploy-preview-8876--carbon-components-react.netlify.app/iframe

@dakahn dakahn requested a review from joshblack June 10, 2021 17:58
@sstrubberg
Copy link
Member

image

Is right and left supposed to be hanging off the page like that?

@joshblack
Copy link
Contributor

FYI @laurenmrice this change updates the align prop to make it easier to understand where the popover is relative to the trigger element.

@sstrubberg sstrubberg merged commit e5d9041 into carbon-design-system:main Jun 11, 2021
@jnm2377 jnm2377 mentioned this pull request Jun 22, 2021
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover alignment update
3 participants