-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-table): add data-table to sass modules style package #8844
feat(data-table): add data-table to sass modules style package #8844
Conversation
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 0d1cab6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60ba9fab1f79ec00086ffd91 😎 Browse the preview: https://deploy-preview-8844--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 9ac56b9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60c7a618372c4b0007507d91 😎 Browse the preview: https://deploy-preview-8844--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 0d1cab6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60ba9fab2c64260007df4802 😎 Browse the preview: https://deploy-preview-8844--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 9ac56b9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60c7a618073b4200081066b7 😎 Browse the preview: https://deploy-preview-8844--carbon-components-react.netlify.app |
packages/styles/scss/components/data-table/_data-table-action.scss
Outdated
Show resolved
Hide resolved
packages/styles/scss/components/data-table/_data-table-action.scss
Outdated
Show resolved
Hide resolved
packages/styles/scss/components/data-table/_data-table-action.scss
Outdated
Show resolved
Hide resolved
packages/styles/scss/components/data-table/_data-table-inline-edit.scss
Outdated
Show resolved
Hide resolved
packages/styles/scss/components/data-table/_data-table-skeleton.scss
Outdated
Show resolved
Hide resolved
packages/styles/scss/components/data-table/_data-table-sort.scss
Outdated
Show resolved
Hide resolved
@joshblack Thanks for the review! It prompted me to reorganize this quite a bit. I removed @use '../data-table';
@use '../data-table/skeleton';
.my-datatable {
@include data-table();
}
.my-datatable-skeleton {
@include data-table-skeleton();
} The goal being that users can bring in only the core styles without having to bring in the feature files if they don't need them. I did modify |
Refs #8555
Begins work on bringing
DataTable
to the@carbon/styles
packageChangelog
New
/styles
, including a testTesting / Reviewing
Test is failing for me locally, but I'm not sure why. 🤔 Any suggestions @joshblack?