fix(ContentSwitcher): enable title by default #8750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: e06c67e 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60ad5c4de897200007eb28b9 😎 Browse the preview: https://deploy-preview-8750--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: e06c67e 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60ad5c4d89d50c00077f8d99 😎 Browse the preview: https://deploy-preview-8750--carbon-components-react.netlify.app/iframe |
dakahn
approved these changes
May 24, 2021
sstrubberg
approved these changes
May 25, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8742
Adds a
titleby default to allContentSwitchertabs. A few other possibilities:Redundant, but won't set the
titleby defaultAvoids redundancy, and can pass in either a string or boolean. Will need to opt in to receive this functionality.
Changelog
New
titleby default based ontextpassed in toSwitchTesting / Reviewing
Ensure the
textappears on hover forContentSwitcher