chore(project): update to node 14.17 lts #8704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy Preview for carbon-elements ready! Built with commit 437ff1f |
|
Deploy Preview for carbon-components-react ready! Built without sensitive environment variables with commit 437ff1f https://deploy-preview-8704--carbon-components-react.netlify.app |
joshblack
approved these changes
May 17, 2021
tw15egan
approved these changes
May 17, 2021
tay1orjones
reviewed
May 18, 2021
There was a problem hiding this comment.
@sstrubberg should we also update the configs for circle ci and the github action workflows to be explicitly 14.17 vs 14.x?
|
@tay1orjones in the other PR we were talking about it and 14.x should resolve to 14.17 now that it's LTS so it should be good 👀 |
tay1orjones
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates node to v14.17 LTS.
Changelog
Changed
node-sass&gulp-sassdependencies across the project to allow build process to complete successfully.yarn dedupeto remove dupes.Testing / Reviewing
Make sure this doesn't break our build!