fix(Modal): Increase Overflow menu options z-index with modal open #8694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
|
Deploy Preview for carbon-elements ready! Built with commit f09490c |
|
Deploy Preview for carbon-components-react ready! Built without sensitive environment variables with commit f09490c https://deploy-preview-8694--carbon-components-react.netlify.app |
tw15egan
reviewed
May 17, 2021
tay1orjones
approved these changes
May 18, 2021
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8693
This PR fixes the issue of overflow menu options being displayed behind the modal, when the overflow menu is inside the modal, by increasing the z-index of the overflow-menu-options when modal is open.
I made the change similar to #6757, which was the same issue as this, but for tooltip instead of overflow menu.