fix(button): ignore fill="none" paths on icon svgs #8585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
May 5, 2021
|
if we can update the source SVGs then this additional selector won't be needed |
|
Deploy preview for carbon-elements ready! Built with commit 7442c33 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 7442c33 https://deploy-preview-8585--carbon-components-react.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8583
This PR ignores SVG icon paths with
fill="none"inline styles when applying icon button color styles. An alternative solution would be to check for and remove extraneous layers on the affected assets (for example thePlayOutlineFilled32icon does not appear to require the<path d="M11,23a1,1,0,0,1-1-1V10a1,1,0,0,1,1.4473-.8945l12,6a1,1,0,0,1,0,1.789l-12,6A1.001,1.001,0,0,1,11,23Zm1-11.3821v8.7642L20.7642,16Z"></path>whilePlayOutlineFilled16is unaffected because it does not contain this layer). This approach would be more involved as it requires an audit of every iconTesting / Reviewing
Confirm that all icon button variants render correctly, the temporary PlayOutlineFilled16 and PlayOutlineFilled32 options can be removed before merging