feat(codemod): add in codemod for size prop updates #8570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
force-pushed
the
size-prop-codemod
branch
from
0705f8f
to
363453d
Compare
|
Deploy preview for carbon-elements ready! Built with commit 0705f8f |
|
Deploy preview for carbon-elements ready! Built with commit 55a938c |
|
Deploy preview for carbon-components-react ready! Built with commit 0705f8f https://deploy-preview-8570--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built with commit 55a938c https://deploy-preview-8570--carbon-components-react.netlify.app |
joshblack
suggested changes
May 4, 2021
tw15egan
force-pushed
the
size-prop-codemod
branch
from
2fda605
to
fd441ba
Compare
dakahn
approved these changes
May 5, 2021
tw15egan
force-pushed
the
size-prop-codemod
branch
from
a8ed01d
to
55a938c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8563
Refs #8370
This PR adds in a new codemod to help users convert their old
sizeprop names to the new conventionChangelog
New
size-prop-update.jscontains the codemod that will convert the code to the new syntaxcode-mod-story.jscontains a bunch of current components all using the current naming convention.code-mod-story.jsChanged
TableToolbarActionwas updated to use thesmclass, and marked the old classes for removal in V11Testing / Reviewing
Pull down the PR, then navigate to the
codemodsfolder. From there, runyarn jscodeshift -d -t ./transforms/size-prop-update.js '../packages/react/src/components/Test/code-mod-story.js'.After that has run, you will notice a new file in the react package (
packages/react/src/components/Test/output.jsthat contains the updated code. Paste this code into the associated story incode-mod-story.jsthat contains a feature flag.Verify all components are using the new props, and that nothing has changed visually 🎉
(extra code and stories will be removed after approval / before emerging)