fix(text-input): increase disabled password toggle specificity #8528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 0f1fade |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 0f1fade https://deploy-preview-8528--carbon-components-react.netlify.app |
emyarod
force-pushed
the
8375-disabled-password-visibility-toggle-color
branch
from
7007710
to
6617826
Compare
laurenmrice
requested changes
Apr 30, 2021
There was a problem hiding this comment.
Both Password stories:
- The dots when hiding your password are very dark in g80, g90 and g100 themes in Safari only. Seems like a Safari bug.
Fully controlled password story:
- You should not be able to interact with the input icon functionality. Happens in Firefox/Chrome/Safari
|
the fully controlled story issue will be resolved in #8368 and the Safari issue seems to be an existing problem which I can address separately as it also impacts the text input |
laurenmrice
approved these changes
Apr 30, 2021
emyarod
force-pushed
the
8375-disabled-password-visibility-toggle-color
branch
from
6617826
to
9210585
Compare
dakahn
approved these changes
May 3, 2021
emyarod
force-pushed
the
8375-disabled-password-visibility-toggle-color
branch
from
9210585
to
6cc9c4c
Compare
jnm2377
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8375
related #8366
This PR updates the disabled password toggle selector so that it receives the proper color. It also removes a redundant selector and unnests some style blocks for better readability
Testing / Reviewing
Confirm the disabled password input appears correct and no visual regressions were introduced