feat(StructuredList): add prop for condensed list #8446
Conversation
jnm2377
requested review from
kingtraceyj,
joshblack and
dakahn
and removed request for
a team
|
Deploy preview for carbon-elements ready! Built with commit 486105d |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 486105d https://deploy-preview-8446--carbon-components-react.netlify.app |
|
@jnm2377 Is there a design spec somewhere that you're referencing? Is the removal of the padding-left intentional? |
|
@aagonzales I didn't do anything with the styles, these already exist. I simply added a prop to be able to toggle the styles in the react component. As far as the padding, it seems like that was removed several years ago bc of this issue: #693 |
|
"already supported in vanilla" I think it's that vanilla was never updated. This condensed style matches the old v9 styling of structure list. What you see in the "simple" story is the intended design. I don't think there was ever supposed to be a condensed version with the v10 update. I'll take this to the greater design team and ask them. For that context, we don't mention it in our website docs or include it as a part of the Sketch kit. Just trying to figure out where this ask is actually coming from. |
|
@aagonzales I guess on the dev side we assumed this issue was ok to work on bc no designers ever declined the enhancement in the original issue when Akira asked for input (this was about a year ago). Lmk what design decides. |
|
(in a very joking tone) we were a little distracted in March 2020 so I think this one just fell through the cracks. We talked about it in our design sync today, we think a condensed version is ok to have but this style is is flush as well as condensed and those would be two separate props. I'm going to mock-up a quick spec to demonstrate what I mean. |
|
Ok so adding a condensed list is one issue and there's a second one about adding a prop for flush content instead of hanging content. I know this PR is just about enabling the prop but I think its an old one and was never properly updated with v10 styling. I have talked to the design team and we're ok with having these 4 variants. Or to start simply adding in the indented padding to the left of the first column on the condensed list to match the padding of the default list.
|
|
@kingtraceyj @aagonzales updated to include both options via props. There's a playground story where you can toggle the diff styles to test, and also added knobs to the selection story to view on there. |
Closes #5736
New