Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RadioButtonGroup): clones RadioButton #8283

Merged
merged 3 commits into from
Apr 16, 2021
Merged

fix(RadioButtonGroup): clones RadioButton #8283

merged 3 commits into from
Apr 16, 2021

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Apr 2, 2021 •
edited
Loading

Closes #8225

  • We decided to clone the child (radioButton) instead of forcing our own RadioButton (what we are currently doing) causing issues for users

Testing / Reviewing

@andreancardona andreancardona requested a review from a team as a code owner April 2, 2021 04:25
@andreancardona andreancardona mentioned this pull request Apr 2, 2021
Closed
@andreancardona andreancardona changed the title fix(RadioButtonGroup): clones Radio Button fix(RadioButtonGroup): clones RadioButton Apr 2, 2021
@andreancardona andreancardona mentioned this pull request Apr 2, 2021
Closed
86 tasks
@netlify
Copy link

netlify bot commented Apr 2, 2021

Deploy preview for carbon-elements ready!

Built with commit ec09724

https://deploy-preview-8283--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 2, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit ec09724

https://deploy-preview-8283--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Apr 2, 2021 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit ab17f2f

https://deploy-preview-8283--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 2, 2021 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit ab17f2f

https://deploy-preview-8283--carbon-components-react.netlify.app

@andreancardona andreancardona removed the request for review from tay1orjones April 2, 2021 13:45
@joshblack joshblack mentioned this pull request Apr 5, 2021
Closed
tw15egan
tw15egan approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 6711067 into carbon-design-system:main Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@tw15egan tw15egan tw15egan approved these changes

@vpicone vpicone Awaiting requested review from vpicone

Assignees
No one assigned
Labels
component: radio-button status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RadioButtonGroup usability issue (renders it's own children regardless of given children types)
4 participants
@andreancardona @joshblack @vpicone @tw15egan