Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme): add new color tokens #8241

Merged
merged 13 commits into from
Apr 2, 2021
Merged

feat(theme): add new color tokens #8241

merged 13 commits into from
Apr 2, 2021

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Mar 30, 2021

Closes #8238
Rel: #8149

Adds new color tokens with existing tokens as a fallback. Will need to update again when we release v11 to deprecate existing tokens and use new color tokens without fallback.

Testing / Reviewing

  • Double check that new token names are correct, and are using the correct fallback color: color token list

@jnm2377 jnm2377 requested a review from a team as a code owner March 30, 2021 20:27
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2021 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@jnm2377
Copy link
Contributor Author

jnm2377 commented Mar 30, 2021

I have read the DCO document and I hereby sign the DCO.

@netlify
Copy link

netlify bot commented Mar 30, 2021

Deploy preview for carbon-elements ready!

Built with commit ba91ec6

https://deploy-preview-8241--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 30, 2021

Deploy preview for carbon-components-react ready!

Built with commit ba91ec6

https://deploy-preview-8241--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Mar 30, 2021 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit c05f203

https://deploy-preview-8241--carbon-elements.netlify.app

@aagonzales
Copy link
Member

@jnm2377 Looks like the button tokens and all the state tokens are missing.

Notion is stupid in that it doesn't load the whole table automatically. You'll need to hit the "load 50 more" button at the bottom.
image

@netlify
Copy link

netlify bot commented Mar 30, 2021 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit c05f203

https://deploy-preview-8241--carbon-components-react.netlify.app

@jnm2377
Copy link
Contributor Author

jnm2377 commented Mar 30, 2021

lol my bad @aagonzales updated! 👍🏽

@jnm2377 jnm2377 requested a review from a team as a code owner March 31, 2021 13:48
tw15egan
tw15egan approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉 👍🏻 ✅

@tw15egan
Copy link
Member

tw15egan commented Mar 31, 2021 •
edited
Loading

@jnm2377 I think we need to add the tokens here to fix the failing tests

@jnm2377
Copy link
Contributor Author

jnm2377 commented Mar 31, 2021

@tw15egan updated! 🤞🏽

aagonzales
aagonzales approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks like they're all there now!

@tw15egan tw15egan mentioned this pull request Apr 1, 2021
Merged
12 tasks
@kodiakhq kodiakhq bot merged commit 8ca2496 into carbon-design-system:main Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@aagonzales aagonzales aagonzales approved these changes

@tw15egan tw15egan tw15egan approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new tokens to theme package
4 participants
@jnm2377 @aagonzales @tw15egan @tay1orjones