fix(UIShell): avoid spreading isSideNavExpanded to non Carbon elements
#8135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 0920f4e |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 0920f4e https://deploy-preview-8135--carbon-components-react.netlify.app |
tw15egan
approved these changes
Mar 19, 2021
andreancardona
approved these changes
Mar 24, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3970
This PR checks the display name of Carbon SideNav children before applying UI Shell specific props to avoid unrecognized prop errors. This is likely a stop gap solution until the UI Shell is refactored
Testing / Reviewing
Confirm that
isSideNavExpandedis only found on components that are expecting this prop