fix(ContentSwitcher): resolve text contrast violations #8130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit b04c265 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit b04c265 https://deploy-preview-8130--carbon-components-react.netlify.app |
Yes, the light variant won't be needed anymore. |
|
Also just talked to Jeannie and we want to change the small divider between the tabs to
|
emyarod
force-pushed
the
6745-content-switcher-text-contrast-updates
branch
from
ab6e607
to
7f2b073
Compare
joshblack
approved these changes
Mar 24, 2021
|
We should make sure we call out this change with the next release notes so people are aware since its a larger visual change. |
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6745
This PR updates the content switcher styles to match the updated spec which passes new text contrast requirements.
cc @aagonzales should we deprecate the light variant of this component and make it identical to the base style?