feat(Select): support warning state #8092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
force-pushed
the
8082-select-warning-state
branch
from
b88b832
to
4752171
Compare
|
Deploy preview for carbon-elements ready! Built with commit b88b832 |
|
Deploy preview for carbon-components-react ready! Built with commit b88b832 https://deploy-preview-8092--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 53f09d5 |
|
Deploy preview for carbon-components-react ready! Built with commit 3537762 https://deploy-preview-8092--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 53f09d5 https://deploy-preview-8092--carbon-components-react.netlify.app |
tay1orjones
approved these changes
Mar 15, 2021
15 tasks
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8082
This PR adds support for warning states in the Select component and fixes an existing issue with the warning icon spacing
Testing / Reviewing
Confirm that the
warnandwarnTextprops function as expected and appear as described in the component spec