fix(Tab): sync tab id with tab panel id #8074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 363dfe1 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 363dfe1 https://deploy-preview-8074--carbon-components-react.netlify.app |
|
It seems like if an |
|
the id prop requirement hasn't been changed since the component was created but if we now want to mark the prop as required then I think that strengthens the case for autogenerated IDs |
dakahn
approved these changes
Mar 22, 2021
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8070
Related #7511
Related #7519
This PR removes auto ID generation to properly sync tab button and tab panel IDs. Autogeneration can be reimplemented if desired, but it may not be necessary
Testing / Reviewing
Confirm the "4.1.2 Name, Role, Value" violations for tab headers are no longer present and that #7511 remains resolved