fix(overflowmenuitem): isDanger should not apply a dividing border #8072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 tasks
|
Deploy preview for carbon-elements ready! Built with commit 83bf736 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 83bf736 https://deploy-preview-8072--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 95da352 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 95da352 https://deploy-preview-8072--carbon-components-react.netlify.app |
tw15egan
requested review from
a team and
thyhmdo
and removed request for
a team
joshblack
approved these changes
Mar 15, 2021
andreancardona
approved these changes
Mar 16, 2021
|
looks good to me as well. |
thyhmdo
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OverflowMenuItemdoesn't need to automatically apply a border/divider when the itemisDangersince thehasDividerprop is available. This was pointed out on slack.Changelog
Changed
OverflowMenuItemhasisDangerTesting / Reviewing
The OverflowMenu playground story now has
isDangerandhasDivideras knobs.