fix: update vanilla loading spinner markup and replace expanded containers with margin #7968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
requested review from
thyhmdo,
tay1orjones and
jnm2377
and removed request for
a team
|
Deploy preview for carbon-elements ready! Built with commit 5d2b127 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 5d2b127 https://deploy-preview-7968--carbon-components-react.netlify.app |
jnm2377
approved these changes
Mar 3, 2021
tay1orjones
approved these changes
Mar 8, 2021
emyarod
requested review from
a team,
jeanservaas and
laurenmrice
and removed request for
thyhmdo,
a team and
jeanservaas
87 tasks
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7946
Closes #7978
ref #5367
ref #7497
ref #7499
This PR updates the vanilla loading spinner SVGs to match the changes from #7499. For the inline loading spinner, the animation container has been reduced to match the actual size of the SVG and the space between the spinner and label has been replaced by a margin to resolve spacing issues referenced in #5367
Testing / Reviewing
Confirm that the vanilla loading and inline loading spinners match the React implementation, and confirm that the inline loading spinner no longer has extra left, top, and bottom spacing due to an oversized container