Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(mdx): fix preview paths #7937

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Mar 1, 2021

Fixes an issue with previews when on the Docs tab after sorting components into groups.

To test, ensure previews showup on the Docs tab

@netlify
Copy link

netlify bot commented Mar 1, 2021

Deploy preview for carbon-elements ready!

Built with commit 71c28d0

https://deploy-preview-7937--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 1, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 71c28d0

https://deploy-preview-7937--carbon-components-react.netlify.app

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicee 🎉

@jnm2377
Copy link
Contributor

jnm2377 commented Mar 2, 2021

I'm seeing this in the ComposedModal Docs tab. When I check our live storybook it also doesn't have a preview. Is this expected or was it supposed to show something here?
Screen Shot 2021-03-01 at 8 24 31 PM

@tw15egan
Copy link
Member Author

tw15egan commented Mar 2, 2021

@jnm2377 good catch! Updated

@kodiakhq kodiakhq bot merged commit ba8501e into carbon-design-system:master Mar 2, 2021
@dakahn dakahn mentioned this pull request Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants