feat(Notification): add onClose support #7918
Conversation
|
Deploy preview for carbon-elements ready! Built with commit 741f30e |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 741f30e https://deploy-preview-7918--carbon-components-react.netlify.app |
| @@ -266,25 +267,33 @@ export function ToastNotification({ | |||
| [`${prefix}--toast-notification--${kind}`]: kind, | |||
| }); | |||
|
|
|||
| const handleClose = useCallback( | |||
| (evt) => { | |||
| if (!onClose || onClose(evt) !== false) { | |||
There was a problem hiding this comment.
For the onClose(evt) !== false branch, would we more so want people to be able to configure visibility of the close button if they aren't able to dismiss/close the notification?
There was a problem hiding this comment.
this is for the visibility of the notification itself, similar to how the visibility of modals is controlled rather than the visibility of the modal close button
There was a problem hiding this comment.
@emyarod right, the way I interpreted it was that if the onClose prop is called and returns false then it will prevent the close from happening. Is that correct?
If so, then I was just asking that if the notification is unable to be dismissed (the onClose prop would return false) it seems like there would need to be some indicator of that. I think from my comment that was hiding the button if someone couldn't dismiss the notification but it could be something else, for sure.
There was a problem hiding this comment.
wouldn't this be left up to the consumer to resolve? similar to how we provide this API in our modals
emyarod
force-pushed
the
7859-notification-onclose
branch
from
4109320
to
e3d676d
Compare
|
Hi. I've just upgraded to Edit... I might have misread the state of affaires… I thought it's already merged, but now I see that it's just approved… the question holds though :-) |
|
@emyarod is this good to go? |
emyarod
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Closes #7859
This PR adds support for the
onClosemethod on ToastNotification and InlineNotification. Similar to the ComposedModal the default close behavior can be avoided if the method returnsfalseChangelog
New
onClosesupport in ToastNotification and InlineNotificationTesting / Reviewing
Confirm that the
onCloseaction appears in the storybook action logger. When editing the return value of the method locally, returningfalseshould prevent the notification from closing