fix(tabs): remove Safari specific overflow indicator margins #7917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 4a772a3 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 4a772a3 https://deploy-preview-7917--carbon-components-react.netlify.app |
joshblack
approved these changes
Feb 26, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7906
This PR removes previously needed margins for the tab overflow indicators in Safari
Testing / Reviewing
Reduce the width of the viewport so that scrolling tabs are enabled and the indicators appear. This will not be testable in the storybook due to custom properties support, so this will need to be viewed with custom properties disabled locally