fix(MultiSelect): adds and updates list item aria, fixes type bug w/ itemToString #7889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Feb 24, 2021
dakahn
changed the title
|
Deploy preview for carbon-elements ready! Built with commit a502474 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit a502474 https://deploy-preview-7889--carbon-components-react.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6840
The selected state of a MultiSelect option wasn't being read since
aria-selectedwasn't being appropriately applied (due to us not using Downshift'suseMultipleSelectionhook). Thea11y-status-messagewas readingselectedItemas "undefined" due to a type error passing an object of multiple selected items toitemToString().Changelog
New
aria-labelfor better cross browser/cross reader support and so we don't have to rely on Downshift's a11y-status-messagedivChanged
itemToStringto loop through multiple selectionsgetItemPropsthat checks and apply'saria-selectedcorrectly for multiple items*Testing / Reviewing
Using a screen reader (NVDA, VoiceOver, or JAWS) confirm that the SELECTED state of a list item is announced on selection and on focus
*we dont add
aria-selected="false"to unselected list items as per recommendation seen here