fix(UIShell): fix voiceover issue with closed SideNav #7864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit cb8f150 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit cb8f150 https://deploy-preview-7864--carbon-components-react.netlify.app |
dakahn
approved these changes
Feb 24, 2021
jnm2377
approved these changes
Feb 24, 2021
tw15egan
added
status: ready to merge 🎉
and removed
Mobile 📱
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6286
Fixes an issue that was causing the
SideNavto be read by a screen reader on iOS when theSideNavwas collapsedChangelog
New
aria-hiddentoggle based on theSideNavexpanded stateTesting / Reviewing
I tested on iOS 14.5, would be great to verify this fix works on iOS13 as well.