fix(DataTableSkeleton): fix support for visible headers #7855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 34e5a04 |
|
Deploy preview for carbon-components-react ready! Built with commit 34e5a04 https://deploy-preview-7855--carbon-components-react.netlify.app |
joshblack
approved these changes
Feb 24, 2021
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
tw15egan
force-pushed
the
table-skeleton
branch
from
7fe9311
to
64299c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7302
Fixes support for visible headers in
DataTableSkeleton.headersprop was not being properly passed down toDataTableSkeleton. Now, if theheadersarray exists, it is fed into the Table headers. If not, it renders the skeleton spans as before.Changelog
Changed
headersprop now works as expectedTesting / Reviewing
Ensure table headers now render on
DataTableSkeleton