fix(DatePicker): allow locale object to be passed in to flatpickr #7834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
force-pushed
the
date-picker-update
branch
from
480075b
to
23edd71
Compare
|
Deploy preview for carbon-elements ready! Built with commit 480075b |
joshblack
approved these changes
Feb 17, 2021
|
Deploy preview for carbon-components-react ready! Built with commit 480075b https://deploy-preview-7834--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 1fdff32 |
|
Deploy preview for carbon-components-react ready! Built with commit 23edd71 https://deploy-preview-7834--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 1fdff32 https://deploy-preview-7834--carbon-components-react.netlify.app |
dakahn
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7823
This PR allows additional Flatpickr props, such as
firstDayOfWeek, to be passed down via thelocalepropChangelog
New
localetoflatpickrand only accepting a locale string (thus stripping additional props), it now checks iflocaleis a string or object.enif not provided), then spread additional passed down props to the newlocaleDataobject.localeDatais then passed down to `Flatpickr, either as an object containing the locale data and additional props, or just the locale dataTesting / Reviewing
Locally, edit the
DatePicker-story.jsand try the following 3 variants ad ensure it renders as expected