Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loading) small loader not spinning on fixed position #7818

Conversation

peter310
Copy link

Closes carbon-design-system/carbon-website#2106

change the height and width on small loader class to fix the issue

@peter310 peter310 requested a review from a team as a code owner February 16, 2021 22:24
@netlify
Copy link

netlify bot commented Feb 16, 2021

Deploy preview for carbon-elements ready!

Built with commit eccb7bb

https://deploy-preview-7818--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 16, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit eccb7bb

https://deploy-preview-7818--carbon-components-react.netlify.app

@tw15egan
Copy link
Member

tw15egan commented Feb 17, 2021

Hey there @peter310, this is doubling the overall height/width of the small loading, which I don't think is intended.

Screen Shot 2021-02-17 at 11 17 09 AM

If you are trying to resolve the comment about

in the demo the small loading is wobbling around and not staying in place.

I believe we just need to add position: absolute to .bx--loading__svg as an override on the Carbon website repo, as this is a website-specific bug. Specifically, we can add it here https://github.com/carbon-design-system/carbon-website/blob/master/src/components/ComponentDemo/ComponentDemo.module.scss

Specifically,

  [class*='--loading--small'] [class*='--loading__svg'] {
    position: absolute;
  }

I'm going to close this out, but feel free to make a PR on the website repo with the suggested change. Thanks!

@tw15egan tw15egan closed this Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[live demo] loading audit bugs
2 participants