Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guidelines): audit-guidelines-icons-button-label #7814

Closed
wants to merge 8 commits into from
Closed

fix(guidelines): audit-guidelines-icons-button-label #7814

wants to merge 8 commits into from

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Feb 16, 2021

Closes (Carbon Website): carbon-design-system/carbon-website#1498

  • Adds an aria-label in the Tooltip to fix a11y violation

  • Adds: ariaLabel: {tooltipText} to TooltipDefinition component

@netlify
Copy link

netlify bot commented Feb 16, 2021

Deploy preview for carbon-elements ready!

Built with commit c6a38c0

https://deploy-preview-7814--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 16, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit c6a38c0

https://deploy-preview-7814--carbon-components-react.netlify.app

@andreancardona
Copy link
Contributor Author

CLOSING PR - merge conflicts and tests are conflicting 🤦🏽‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant