fix: update listbox titleText proptypes to match Dropdown #7785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
reviewed
Feb 11, 2021
| @@ -191,7 +191,7 @@ export default class ComboBox extends React.Component { | |||
| * Provide text to be used in a `<label>` element that is tied to the | |||
| * combobox via ARIA attributes. | |||
| */ | |||
| titleText: PropTypes.string, | |||
| titleText: PropTypes.oneOfType([PropTypes.string, PropTypes.node]), | |||
There was a problem hiding this comment.
I believe a string will still be considered a node and not throw any warnings
Suggested change
| titleText: PropTypes.oneOfType([PropTypes.string, PropTypes.node]), | |
| titleText: PropTypes.node, |
There was a problem hiding this comment.
it was lifted directly from the dropdown but I updated them all across the board
|
Deploy preview for carbon-elements ready! Built with commit 053f611 |
|
Deploy preview for carbon-components-react ready! Built with commit 053f611 https://deploy-preview-7785--carbon-components-react.netlify.app |
emyarod
force-pushed
the
7779-update-combobox-proptypes
branch
from
759656c
to
053f611
Compare
emyarod
changed the title
andreancardona
approved these changes
Feb 11, 2021
andreancardona
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
This was referenced Feb 18, 2021
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7779
This PR updates the ComboBox titleText prop definition to support nodes in addition to strings. This increases the parity between the listbox components
Testing / Reviewing
Confirm no proptype warnings are emitted when adding rich content to a ComboBox title