feat(button): add selected state to icon only ghost button #7784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 7cdc072 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 7cdc072 https://deploy-preview-7784--carbon-components-react.netlify.app |
aagonzales
approved these changes
Feb 11, 2021
joshblack
approved these changes
Feb 15, 2021
tay1orjones
approved these changes
Feb 23, 2021
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #7757
Initial PR adding in
selectedsupport to icon only ghost buttons. More variants could be added later if needed.Changelog
New
isSelectedprop toButton, will only renderisSelectedstyles ifkind="ghost"andhasIconOnlyprops are suppliedTesting / Reviewing
Go to
Button-->Playgroundand check theisSelectedknob. Nothing should change. Now change thekindknob toghostand the icon only button should receiveselectedstyles.