feat(ComboBox): support warning state #7733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
requested review from
tw15egan,
andreancardona,
a team and
kingtraceyj
and removed request for
a team
|
Deploy preview for carbon-elements ready! Built with commit 639f32a |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 639f32a https://deploy-preview-7733--carbon-components-react.netlify.app |
kingtraceyj
approved these changes
Feb 3, 2021
joshblack
approved these changes
Feb 9, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
This was referenced Feb 16, 2021
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7685
This PR adds support for the warning state to the ComboBox component
Changelog
New
warnandwarnTextpropTesting / Reviewing
Confirm combobox warning state matches existing components that support the
warnprop