Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi-select): prevent flex child from overflowing from container #7725

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Feb 2, 2021

Closes #7723

related #7535 unblocks #7722

This PR fixes a flexbox issue in Firefox version <87 so that the filterable multiselect input field does not overflow out of its parent container

Testing / Reviewing

Confirm the filterable multiselect input focus outline does not get cut off on Firefox version <87

@netlify
Copy link

netlify bot commented Feb 2, 2021

Deploy preview for carbon-elements ready!

Built with commit b6435ce

https://deploy-preview-7725--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 2, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit b6435ce

https://deploy-preview-7725--carbon-components-react.netlify.app

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in Firefox 👍 ✅

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in Firefox and does not get cutoff 👍🏻

@kodiakhq kodiakhq bot merged commit 1b0cef4 into carbon-design-system:master Feb 3, 2021
@emyarod emyarod mentioned this pull request Feb 4, 2021
60 tasks
@emyarod emyarod deleted the 7723-filterable-multiselect-input-container-overflow branch February 4, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filterable multiselect input overflows out of the parent container
4 participants