fix(TextInput): fixes hover, focus issues with visibility icon #7680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Jan 27, 2021
tw15egan
requested review from
joshblack,
a team,
shinytoyrobots and
johnbister
and removed request for
a team and
shinytoyrobots
joshblack
approved these changes
Jan 27, 2021
|
Deploy preview for carbon-elements ready! Built with commit a7c09c7 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit a7c09c7 https://deploy-preview-7680--carbon-components-react.netlify.app |
andreancardona
approved these changes
Jan 28, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
status: visual review 🔍
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7678
The visibility icon was inheriting
currentColorwhich was causing issues in dark themes. This increases specificity so that the proper colors are used across all themes.While working on this, I also noticed issues with keyboard navigation, so this also adds in focus styles / cleans up the box model
Changelog
New
Changed
Testing / Reviewing
Ensure you can tab to password visibility icon, and see focus styles
Ensure the hover fill is correct across themes