fix(sketch): match symbol names to existing format #7648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 6e66f09 |
joshblack
approved these changes
Jan 25, 2021
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 6e66f09 https://deploy-preview-7648--carbon-components-react.netlify.app |
60 tasks
andreancardona
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
This was referenced Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7614
related #6485
This PR updates the symbol naming logic in the Sketch plugin to match the current format for symbol names in the existing Sketch library. This change will fix the regression of existing artboards not being updated when the icons sync command is run.
This is just a preliminary change and follow up PRs will address issues related to the newly synced artwork getting skewed and artboard positioning after the sync command
Changelog
Changed
Testing / Reviewing
Confirm that existing artboards are not duplicated when the icons sync command is run
carbon-elements.sketchplugin.zip