Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storybook-config): add Carbon Theme & Type Panel #7569

Merged
merged 34 commits into from
Feb 1, 2021
Merged

feat(storybook-config): add Carbon Theme & Type Panel #7569

merged 34 commits into from
Feb 1, 2021

Conversation

aledavila
Copy link
Contributor

@aledavila aledavila commented Jan 14, 2021 •
edited
Loading

Closes #7569

Added

Carbon Theme Panel and Type Panel

Make sure storybook is working as intended. Make sure Theme and Type panels are showing up and work as intended.

@netlify
Copy link

netlify bot commented Jan 14, 2021 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 3bf7dbb

https://deploy-preview-7569--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 14, 2021 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 3bf7dbb

https://deploy-preview-7569--carbon-components-react.netlify.app

andreancardona and others added 14 commits January 14, 2021 13:22
@andreancardona
storybook config custom preset with create-react-app package
0b70528
@andreancardona
storybook config custom presets - need to transpile
b517bf2
@andreancardona
storybook-config-custom-presets: added babel cli & babel core
42dffe4
Merge branch 'master' of github.com:carbon-design-system/carbon into …
36f4fd8 
…storybook-config-custom-presets
Merge branch 'storybook-config-custom-presets' of github.com:aledavil…
79512d7 
…a/carbon into storybook-config-custom-presets
Merge branch 'master' of github.com:carbon-design-system/carbon into …
8a962b0 
…storybook-config-custom-presets
@andreancardona
stuck on panel rendering with custom properties variable
62e83b6
@andreancardona
stuck on panel rendering with custom properties variable
8456773
@andreancardona
testing file path
41a3453
Merge branch 'master' of github.com:carbon-design-system/carbon into …
e0e0aa4 
…storybook-config-custom-presets
Merge branch 'storybook-config-custom-presets' of github.com:aledavil…
9ea715e 
…a/carbon into storybook-config-custom-presets
@andreancardona
panel is showing up - just not fully functioning
8b7a5f8
Merge branch 'storybook-config-custom-presets' of github.com:aledavil…
9a759fd 
…a/carbon into storybook-config-custom-presets
feat(storybook-config): add theme and type addon panels
eebbc2c
@aledavila aledavila marked this pull request as ready for review January 20, 2021 20:59
@aledavila aledavila requested a review from a team as a code owner January 20, 2021 20:59
@andreancardona andreancardona changed the title feat(storybook-config): add custom panel feat(storybook-config): add Carbon Theme Panel & Type Panel Jan 20, 2021
@andreancardona andreancardona changed the title feat(storybook-config): add Carbon Theme Panel & Type Panel feat(storybook-config): add Carbon Theme & Type Panel Jan 20, 2021
joshblack
joshblack suggested changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Seems like there are some formatting issues with prettier and lint that need to get addressed, also left a couple of comments.

The other CI error is from deduping, I think you can run yarn dedupe it should fix that issue for you automatically 🔥

packages/react/.storybook/addon-carbon-theme/components/Panel.js Outdated Show resolved Hide resolved
config/storybook-preset-carbon/package.json Outdated Show resolved Hide resolved
config/storybook-preset-carbon/index.js Outdated Show resolved Hide resolved
config/storybook-preset-carbon/index.js Outdated Show resolved Hide resolved
config/storybook-preset-carbon/.babelrc.js Show resolved Hide resolved
dakahn
dakahn approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@tw15egan
Copy link
Member

This is looking really awesome! Nice work 🎉 Left a few comments, but everything is working great.

@andreancardona andreancardona enabled auto-merge (squash) January 25, 2021 22:11
joshblack
joshblack suggested changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Left a couple of comments, another question I had was if you could add in dependencies to address the warnings from Yarn:

image

I think the missing packages are babel-loader, react, react-dom, and react-is

config/storybook-preset-carbon/carbon-theme-addon/src/components/LonelyPanel.js Outdated Show resolved Hide resolved
config/storybook-preset-carbon/carbon-theme-addon/src/preset.js Show resolved Hide resolved
config/storybook-preset-carbon/package.json Outdated Show resolved Hide resolved
@aledavila
Copy link
Contributor Author

@joshblack should be good now ! thanks for the feedback

@aledavila
Copy link
Contributor Author

@joshblack my updates were pushed up for checking the merge conflicts are from lee's addon update.

@andreancardona andreancardona mentioned this pull request Jan 29, 2021
Merged
joshblack
joshblack approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just had one comment

config/storybook-preset-carbon/carbon-theme-addon/src/components/Panel.js Outdated Show resolved Hide resolved
@andreancardona andreancardona merged commit 0bdea69 into carbon-design-system:master Feb 1, 2021
auto-merge was automatically disabled February 1, 2021 22:06

Pull request was closed

@andreancardona andreancardona mentioned this pull request Feb 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona left review comments

@joshblack joshblack joshblack approved these changes

@dakahn dakahn dakahn approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan

Assignees
No one assigned
Labels
status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aledavila @tw15egan @joshblack @andreancardona @dakahn