Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(code-snippet): remove min-width rules for improved responsiveness #7420

Merged
merged 4 commits into from
Dec 9, 2020
Merged

fix(code-snippet): remove min-width rules for improved responsiveness #7420

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eeeb8ae
fix(code-snippet): remove min-width rules
emyarod Dec 8, 2020
e1cdb9c
docs(CodeSnippet): remove forced 50% width on story
emyarod Dec 8, 2020
e212751
Merge branch 'master' into 7406-code-snippet-min-width
kodiakhq[bot] Dec 9, 2020
3d9f9a6
Merge branch 'master' into 7406-code-snippet-min-width
kodiakhq[bot] Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/components/src/components/code-snippet/_code-snippet.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@

display: flex;
align-items: center;
min-width: rem(320px);
max-width: rem(760px);
height: $carbon--spacing-08;
padding-right: $carbon--spacing-08;
Expand Down Expand Up @@ -164,7 +163,6 @@
@include bx--snippet;

display: flex;
min-width: rem(320px);
max-width: 100%;
padding: $carbon--spacing-05;

Expand Down
8 changes: 3 additions & 5 deletions packages/react/src/components/CodeSnippet/CodeSnippet-story.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,8 @@ export const inline = () => (
);

export const multiline = () => (
<div style={{ width: '50%' }}>
<CodeSnippet {...props()} type="multi" feedback="Copied to clipboard">
{` "scripts": {
<CodeSnippet {...props()} type="multi" feedback="Copied to clipboard">
{` "scripts": {
"build": "lerna run build --stream --prefix --npm-client yarn",
"ci-check": "carbon-cli ci-check",
"clean": "lerna run clean && lerna clean --yes && rimraf node_modules",
Expand Down Expand Up @@ -61,8 +60,7 @@ export const multiline = () => (
"@babel/preset-react": "^7.10.0",
"@babel/runtime": "^7.10.0",
"@commitlint/cli": "^8.3.5",`}
</CodeSnippet>
</div>
</CodeSnippet>
);

export const singleline = () => (
Expand Down