feat(tooltip): add definition tooltip #714

aledavila · 2018-04-19T15:35:48Z

Overview

https://github.ibm.com/carbon/issues/issues/618
https://github.ibm.com/carbon/issues/issues/549#issuecomment-4988198
#771

Added

Added new tooltips with on click tooltip being the default.
Added definition tooltip
Added icon tooltip

Removed

Removed on hover tooltip.
Removed simple tooltip

Changed

Simple tooltip is just for defining the icon.
Default font weight is now normal. Bold is a modifier.

Notes

Tayler needs to sign of and look at styles.

alisonjoseph · 2018-04-19T17:01:48Z

@aledavila These don't look like they are related to this PR? #618 #549

aledavila · 2018-04-19T17:11:32Z

@alisonjoseph yes you are right sorry. those are the issue #s in IBM carbon repo no this repo

aledavila · 2018-04-19T17:14:33Z

Fixed the links

alisonjoseph

Overall looks good 😄

Looks like the triangle needs to move 1px down? Screen shot of a screen shot I zoomed in on.

Changing the functionality of the existing tooltip would be a breaking change. (from hover to click). Would maybe be better to add it as a new variant or v2, thoughts?

alisonjoseph · 2018-04-19T17:02:57Z

src/components/tooltip/_tooltip.scss

-      max-width: rem(240px);
-      padding: $spacing-lg;
+      max-width: rem(170px);
+      padding: rem(10px) $spacing-xs;


Might be a question for design but can rem(10px) be tweaked up or down to fit into our spacing scale?

It should be 8px

aledavila · 2018-04-19T17:46:22Z

Thanks I’ll look into the changes. As it stands how the changes were made it doesn’t break anything rather people who have the tooltip implemented would have to click on it now instead of hovering when they pull the new changes. But i don’t know how you guys prefer to handle that.

Yea I’ll ask Tayler about the changes probably better to have the padding all spacing-xs.

asudoh · 2018-04-19T22:13:46Z

Agreed with @alisonjoseph that looks great overall 🎉 - Thanks @aledavila!

The only question I have is how to handle the change in behavior, which would need to involve designers (CC @carbon-design-system/design) - Should we introduce some way to keep the older behavior, or should we try something to ensure that the change in behavior does not come with a surprise to our consuming services...?

aledavila · 2018-04-20T14:51:55Z

@alisonjoseph I changed the 1 pixel that was off. I'll ask Tayler about the other padding issue when she gets back.

aagonzales · 2018-04-20T15:46:18Z

Changing the functionality of the existing tooltip would be a breaking change. (from hover to click). Would maybe be better to add it as a new variant or v2, thoughts?

I think making it a v2 and deprecating the v1 version with Carbon V10 would be fine. Consumers just won't ever automatically get those update, correct? They'll have to manually update it to v2?

alisonjoseph · 2018-04-20T15:48:52Z

correct @aagonzales. That's how we've been handling other components with breaking changes.

aledavila · 2018-04-20T16:46:08Z

Oh I see. Can someone explain how that process is or where to make it a V2 instead?

alisonjoseph · 2018-04-20T17:16:20Z

Looks like the process for the other components is just updating the classname, so bx--tooltip-v2 and just make sure that the original tooltip doesn't change. You can see how the v2 input styles are handled in this PR for an example. #712

aledavila · 2018-04-25T15:22:10Z

@alisonjoseph I added the v2 now. I just need to ask Tayler about the padding on the simple tooltip. Everything else should be good.

alisonjoseph · 2018-04-25T15:42:55Z

src/components/tooltip-v2/tooltip-v2--simple.html

@@ -0,0 +1,8 @@
+<div class="bx--tooltip--simple-v2">


Should this class be bx--tooltip-v2--simple?

asudoh

Hi @aledavila great to see you complete V2 split!

asudoh · 2018-04-26T02:37:42Z

src/components/tooltip-v2/migrate-to-7.x.md

@@ -0,0 +1,25 @@
+### HTML


Given V2 is newly introduced component, does this migration guide still make sense? One thing that comes to my mind is V1 to V2 migration guide. Another approach may be simply keeping the README in-sync with what V2 does.

tay-aitken · 2018-04-26T15:50:08Z

@aledavila can you create a staging link so that I can inspect the element and see how everything looks. Thanks! This will help me make a decision about the padding.

tay-aitken · 2018-04-27T17:28:19Z

aledavila · 2018-05-04T03:43:19Z

@alisonjoseph

Ignore the colors. They will be updated once TJs updated colors are merged. The CSS tooltips have the right color but as a hex for the time being. Renaming Default Tooltip to Interactive Tooltip is more complex than simply changing file name. Possible workaround could be name change in website itself.

Definition: I changed the definition tooltip completely and took made it a separate element instead of creating it with a before. It helped with being able to give it a max width and if more than the max widt
h it will wrap appropriately. And re did the CSS for it.

Default: As for the JS I added the prevent close when clicking inside the tooltip. Only close when clicking outside.

Simple --> Icon: Simple tooltip is now Icon only tooltip.

alisonjoseph

LGTM! 👍

asudoh

LGTM basically - Great to see this PR getting there @aledavila! Just one little thing - Is it possible for you to remove yarn-error.log and package-lock.json from the source control before merging? Thanks!

alisonjoseph · 2018-05-17T19:36:02Z

@aledavila since the demo template changes have been merged in to the v9 branch, would be nice to update this from html to handlebar templates before we merge it in.

asudoh · 2018-05-18T07:19:47Z

^ Yes it'll be nice - Simple rename from .html to .hbs will work for now, but great to merge several component variant's markup using the power of Handlebars. Feel free to ping me if you have any questions - Thanks!

alisonjoseph

Would be good to add correct aria roles. Ref #771

https://www.w3.org/TR/wai-aria-practices/#tooltip

WAI-ARIA Roles, States, and Properties
The element that serves as the tooltip container has role tooltip.
The element that triggers the tooltip references the tooltip element with aria-describedby.

tw15egan

Just a few tiny changes, but other than that it looks great!

tw15egan · 2018-05-18T15:35:12Z

src/components/tooltip/_tooltip.scss

    border: 1px solid $ui-03;
+    border-radius: 4px;


Can we switch this to rem(4px)?

tw15egan · 2018-05-18T15:35:24Z

src/components/tooltip/_tooltip.scss

+    margin-top: $spacing-sm;
+    padding: $spacing-xs;
+    color: $inverse-01;
+    border-radius: 4px;


Can we switch this to rem(4px)?

tw15egan · 2018-05-18T15:35:32Z

src/components/tooltip/_tooltip.scss

+      left: 0;
+      width: 0.6rem;
+      height: 0.6rem;
+      margin-left: 24px;


Can we switch this to rem(24px)?

tw15egan · 2018-05-18T15:35:46Z

src/components/tooltip/_tooltip.scss

      margin-left: 50%;
-      color: $text-01;
+      padding: $spacing-2xs;
+      border-radius: 4px;


Same as above

aledavila · 2018-05-21T01:48:37Z

WIP: working on accessibility

alisonjoseph · 2018-05-22T16:11:44Z

src/components/tooltip/tooltip.hbs

-    <path d="M8 0C3.6 0 0 3.6 0 8s3.6 8 8 8 8-3.6 8-8-3.6-8-8-8zm0 4c.6 0 1 .4 1 1s-.4 1-1 1-1-.4-1-1 .4-1 1-1zm2 8H6v-1h1V8H6V7h3v4h1v1z"></path>
-  </svg>
-</a>
+<div class="bx--tooltip__label">


We should add the aria-describedby here <div class="bx--tooltip__label" aria-describedby="unique-tooltip">

alisonjoseph · 2018-05-22T16:12:04Z

src/components/tooltip/tooltip.hbs

-</a>
+<div class="bx--tooltip__label">
+  Tooltip Label
+  <div tabindex="0" data-tooltip-trigger data-tooltip-target="#unique-tooltip" role="tooltip" aria-labelledby="unique-tooltip" class="bx--tooltip__trigger">


you can remove aria-labelledby="unique-tooltip" here

alisonjoseph

Looks good! 🎉

* feat(tooltip): add definition tooltip * feat(tooltip): add on click tooltip * chore(tooltip): simple info tooltip * fix(tooltip): fix arrowhead 1 pixel * chore(tooltip): add v2 of tooltip in seperate folder * chore(tooltip): add previous version of tooltip * chore(tooltip): add files to globals * fix(tooltip): fix simple tooltip class name * chore(tooltip): add definition tooltip to readme * chore(tooltip): add tooltip icon * chore(tooltip): change definition tooltip to seperate element * fix(tooltip): fix merge conflict again * chore(tooltip): removed v2 and added new color variables * chore(tooltip): add bold modifier * chore(tooltip): updated migration to v9 and readme files * chore(tooltip): add focus to definition * chore(tooltip): remove tab * fix(tooltip): added accessibility aria tags * chore(tooltip): change arrow to be a dom element * chore(tooltip): change aria label location * chore(tooltip): attribute name change

* feat(inputs): fixed old pr and added inputs and colors work (#756) * feat(inputs): fixed old pr and added inputs and colors work * feat(inputs): fixed inline select * chore(devenv): introduced parameterized demo HTML (#579) * feat(code-snippet): Add new Code snippet variation and styles (#761) * feat(code-snippet): Update code snippet styles and names * feat(code-snippet): Update font size * chore: cleanup html files * feat(code-snippet): Update feedback copy tooltip to match new styles * chore: cleanup javascript * feat(code-snippet): Update copy tooltip styles * chore: cleanup js * feat(code-snippet): Update click event to only happen on button * chore: Add back support for deprecated class names * feat(code-snippet): Update tooltip styles and positioning * fix: update tooltip positioning for inline snippet * V9 merge 05162018 (#773) * fix(data-table-v2): fix the icon that becomes small when column header wraps, resolves #720 (#742) * fix(tooltip): Firefox overflowing text when you have a long enough string without spaces (#737) * feat(dropdown): added inline dropdown, style changes to dropdown, fixed link in data table readme (#746) * feat(dropdown): added inline dropdown * feat(dropdown): fixed js * docs(components): add component model explainer (#739) * fix(grid): center grid at largest breakpoint (#747) * fix(letter-spacing): Remove letter-spacing (#748) * fix(letter-spacing): remove letter-spacing across the board * fix(letter-spacing): change hard-coded letter-spacing values to use the mixin * fix(select): added disabled styling to option in select (#751) * fix(select): added disabled styling to select item * fix(select): removed disabled * fix(select): added cursor not allowed * fix(dropdown): added tabindex logic to dropdown (#749) * fix(input): remove red focus ring when input marked as required firefox (#750) * fix(multi-select): fixed width and hover color (#752) * feat(Skeleton-states): Add skeleton state styles (#713) * feat(skeleton): Add skeleton loading mixin and styles * feat(skeleton): Add skeleton icon styles * feat(skeleton): Add skeleton styles to components * feat(skeleton): Add structured list skeleton * feat: skeleton styles * feat: add skeleton demo html * feat: update skeleton html * feat(skeleton-states): Update accordion skeleton styles * feat(skeleton-states): Update accordion * chore: Update px to rem * chore: remove duplicate code * chore: Add correct color value for skeleton state * feat(skeleton-states): Update data table * fix(skeleton-states): Add helper-mixins import to components using skeleton states (#755) * fix(data-table): update data-table to use the new search component (#754) * fix(structured-list): Update header alignment to bottom to match designs (#753) * feat(truncation): add truncation classes (#757) * feat(truncation): add truncation classes * fix(truncation): update truncation classes to be more semantic * fix(truncation): use prefix variable * fix(structured-list): fixed column header text size (#766) * fix(structured-list): fixed column header text size * chore(structured-list): deleted extra file * fix(forms): Add helper-mixins import (#767) * fix(helper-classes): import vars file (#768) * fix(code-snippet): Update templates (#779) * fix(code-snippet): Update skeleton state styles * fix: swap code and pre tag nesting order * fix(code-snippet): Update hbs template for code snippet * fix: spelling error * chore: remove old files * chore: move changes from PR 774 to this * fix: Update click event to run on button * fix(pagination): bring v2 version back (#782) * chore(devenv): fix full-render demo (#783) * V9 merge 05182018 (#785) * feat(dropdown): added inline dropdown, style changes to dropdown, fixed link in data table readme (#746) * feat(dropdown): added inline dropdown * feat(dropdown): fixed js * fix(letter-spacing): Remove letter-spacing (#748) * fix(letter-spacing): remove letter-spacing across the board * fix(letter-spacing): change hard-coded letter-spacing values to use the mixin * fix(dropdown): added tabindex logic to dropdown (#749) * feat(Skeleton-states): Add skeleton state styles (#713) * feat(skeleton): Add skeleton loading mixin and styles * feat(skeleton): Add skeleton icon styles * feat(skeleton): Add skeleton styles to components * feat(skeleton): Add structured list skeleton * feat: skeleton styles * feat: add skeleton demo html * feat: update skeleton html * feat(skeleton-states): Update accordion skeleton styles * feat(skeleton-states): Update accordion * chore: Update px to rem * chore: remove duplicate code * chore: Add correct color value for skeleton state * feat(skeleton-states): Update data table * fix(font-face): bring missing $css--font-face reference back (#778) Fixes #777. * chore(devenv): update variant labels (#784) * chore(devenv): update variant labels * chore(devenv): modal config update * feat(tooltip): add definition tooltip (#714) * feat(tooltip): add definition tooltip * feat(tooltip): add on click tooltip * chore(tooltip): simple info tooltip * fix(tooltip): fix arrowhead 1 pixel * chore(tooltip): add v2 of tooltip in seperate folder * chore(tooltip): add previous version of tooltip * chore(tooltip): add files to globals * fix(tooltip): fix simple tooltip class name * chore(tooltip): add definition tooltip to readme * chore(tooltip): add tooltip icon * chore(tooltip): change definition tooltip to seperate element * fix(tooltip): fix merge conflict again * chore(tooltip): removed v2 and added new color variables * chore(tooltip): add bold modifier * chore(tooltip): updated migration to v9 and readme files * chore(tooltip): add focus to definition * chore(tooltip): remove tab * fix(tooltip): added accessibility aria tags * chore(tooltip): change arrow to be a dom element * chore(tooltip): change aria label location * chore(tooltip): attribute name change * chore(files): remove yarn-error.log (#800) * chore(package): remove npm5 lockfile and add lockfile to gitignore (#803) * V9 merge 05212018 (#801) * feat(dropdown): added inline dropdown, style changes to dropdown, fixed link in data table readme (#746) * feat(dropdown): added inline dropdown * feat(dropdown): fixed js * feat(Skeleton-states): Add skeleton state styles (#713) * feat(skeleton): Add skeleton loading mixin and styles * feat(skeleton): Add skeleton icon styles * feat(skeleton): Add skeleton styles to components * feat(skeleton): Add structured list skeleton * feat: skeleton styles * feat: add skeleton demo html * feat: update skeleton html * feat(skeleton-states): Update accordion skeleton styles * feat(skeleton-states): Update accordion * chore: Update px to rem * chore: remove duplicate code * chore: Add correct color value for skeleton state * feat(skeleton-states): Update data table * fix(tile): add check to make sure element exists (#786) * feat(data-table-v2): add inline edit styles for cell (#780) * fix(table): Missing border in firefox (#787) * fix(overflow-menu): added different styles for focus and hover (#788) * fix(overflow-menu): added different styles for focus and hover * fix(overflow-menu): fixed danger hover/focus * fix(data-table-v2): remove left positioning from sort icon (#789) * fix(tile): check if is--expanded is set when tile component is loaded (#791) * fix(danger-button): Add correct hover color for icon (#794) * fix(table): removes selected class from row on cancel click (#793) * chore(git): update gitignore for *.log files (#798) * fix(button): bring back primary danger button * chore(package): update lockfile to remove artifactory references (#808) * Light dropdown styles (#809) * feat(dropdown): Add light variation * feat(list-box): Add light variation * Icon updates (#810) * feat(icons): start updating icons * feat(icons): update more icons * feat(icons): continue icon work * feat(icons): finish up icon updates * fix(overflow): fix hover colors on overflow menu * fix(components): some small fixes for v9 (#812) * 732 search (#811) * chore(search): remove icons from search * fix(search): fix default close button offset * fix(form): fixed button width (#819) * fix(docs): Update Component docs (#815) * chore: Remove button docs ref glyphs * fix(docs): Update component docs * fix(code-snippet): fixed a render issue for the light version (#817) * feat(slider): Light variation (#818) * feat(slider): Add light variation * fix: Fix spelling error in all config files * feat(checkbox): Update checkboxes to match new icon set (#822) * feat(checkbox): Update checkboxes to match new icon set * feat: Update checkbox styles * fix: Add code snippet example skeleton state html (#827) * chore(tooltip): change to lowercase 'label' (#836) * fix(search): close button positioning for custom react search (#835) * fix(radio): Update radio + checkbox border colors (#834) * fix(radio-button): update border color * fix(checkbox): update checkbox colors * fix(icons): Update data table v2 & card icons (#826) * fix(icons): Update data table v2 & card icons * fix: Fix toolbar search icon from being cut off * fix(pagination): update colors (#832) * fix(multi-select): update hover color (#830) * fix(v9): small fixes to components (#838) * fix(v9): small fixes to components * fix(tooltip): align focus on icon with text * fix(multi-select): fix HTML structure of multi select (#840) * fix(pagination): fix text input position in pagination V1 (#841) * fix(tooltip): Definition tooltip positioning fix (#843) * fix(tooltip): update tooltip definition markup * fix: Add back in js positioning * chore: cleanup js comments * fix(tooltips: Tooltip a11y (#846) * fix(tooltip): update tooltip definition markup * fix(tooltip): top positioning * fix: A11y fixes * chore: update html/js/readme * chore: revert js changes. * fix(tooltip): position fix (#848) * fix(icons): update icons, other small fixes (#849) * fix(icons): update icons, other small fixes * fix(icon): add a w * fix(code-snippet): fixed feedback not showing up in firefox (#852) * chore: update dev env to work in IE11 (#853) * chore: remove deprecated components (#855) * fix(components): misc fixes for v9 (#854) * fix(inline-dropdown): removed box-shadow * fix(time-picker): fixed arrow being positioned weird in firefox * fix(code-snippet): banner showing up on ie11 * fix(form): remove margins from bx--form-item (#861) * fix(list-box): removed styles on disabled item (#862) * fix(select): position arrow based on bottom rather than top (#864) BREAKING CHANGE: update to v9

* feat(tooltip): add definition tooltip * feat(tooltip): add on click tooltip * chore(tooltip): simple info tooltip * fix(tooltip): fix arrowhead 1 pixel * chore(tooltip): add v2 of tooltip in seperate folder * chore(tooltip): add previous version of tooltip * chore(tooltip): add files to globals * fix(tooltip): fix simple tooltip class name * chore(tooltip): add definition tooltip to readme * chore(tooltip): add tooltip icon * chore(tooltip): change definition tooltip to seperate element * fix(tooltip): fix merge conflict again * chore(tooltip): removed v2 and added new color variables * chore(tooltip): add bold modifier * chore(tooltip): updated migration to v9 and readme files * chore(tooltip): add focus to definition * chore(tooltip): remove tab * fix(tooltip): added accessibility aria tags * chore(tooltip): change arrow to be a dom element * chore(tooltip): change aria label location * chore(tooltip): attribute name change

…system#714) * chore(package): update rollup to version 0.57.0 * chore(package): update lockfile https://npm.im/greenkeeper-lockfile

aledavila added 3 commits April 13, 2018 11:24

feat(tooltip): add definition tooltip

4e20861

feat(tooltip): add on click tooltip

c8494a4

chore(tooltip): simple info tooltip

02a0e6f

alisonjoseph requested changes Apr 19, 2018

View reviewed changes

aledavila requested a review from joshblack April 19, 2018 17:47

fix(tooltip): fix arrowhead 1 pixel

f1b0014

aledavila added 3 commits April 25, 2018 09:36

chore(tooltip): add v2 of tooltip in seperate folder

16a1ba5

chore(tooltip): add previous version of tooltip

13f4fa9

chore(tooltip): add files to globals

bfbf89f

alisonjoseph reviewed Apr 25, 2018

View reviewed changes

asudoh reviewed Apr 26, 2018

View reviewed changes

aledavila added 2 commits April 26, 2018 14:17

fix(tooltip): fix simple tooltip class name

ece80ea

chore(tooltip): add definition tooltip to readme

a4a3ada

marijohannessen mentioned this pull request Apr 27, 2018

[Tooltip]: Class for caret for viewport awareness #542

Closed

aledavila added 2 commits May 3, 2018 21:52

chore(tooltip): add tooltip icon

ada36c1

chore(tooltip): change definition tooltip to seperate element

0ba673e

alisonjoseph approved these changes May 14, 2018

View reviewed changes

asudoh reviewed May 14, 2018

View reviewed changes

aledavila changed the title ~~[WIP] feat(tooltip): add definition tooltip DO NOT MERGE~~ feat(tooltip): add definition tooltip DO NOT MERGE May 15, 2018

aledavila added the visual review needed label May 15, 2018

aledavila changed the title ~~feat(tooltip): add definition tooltip DO NOT MERGE~~ feat(tooltip): add definition tooltip May 15, 2018

aledavila added 2 commits May 16, 2018 10:37

chore(tooltip): add focus to definition

bd428ed

chore(tooltip): remove tab

cd9fbd9

aledavila removed the visual review needed label May 16, 2018

alisonjoseph added the merge conflict label May 17, 2018

alisonjoseph mentioned this pull request May 18, 2018

Tooltip example is invalid HTML and is missing aria-labelling #771

Closed

alisonjoseph requested changes May 18, 2018

View reviewed changes

chore(tooltip): fix merge conflict

30cd525

tw15egan approved these changes May 18, 2018

View reviewed changes

alisonjoseph removed the merge conflict label May 21, 2018

fix(tooltip): added accessibility aria tags

bf5fe3b

joshblack mentioned this pull request May 21, 2018

chore(git): update gitignore for *.log files #798

Merged

chore(tooltip): change arrow to be a dom element

ed23c45

alisonjoseph reviewed May 22, 2018

View reviewed changes

aledavila added 2 commits May 22, 2018 11:45

chore(tooltip): change aria label location

aad8642

chore(tooltip): attribute name change

e569fdb

alisonjoseph approved these changes May 22, 2018

View reviewed changes

alisonjoseph merged commit a22c156 into carbon-design-system:v9 May 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tooltip): add definition tooltip #714

feat(tooltip): add definition tooltip #714

aledavila commented Apr 19, 2018 •

edited

Loading

alisonjoseph commented Apr 19, 2018

aledavila commented Apr 19, 2018

aledavila commented Apr 19, 2018

alisonjoseph left a comment

alisonjoseph Apr 19, 2018

aagonzales Apr 20, 2018

aledavila commented Apr 19, 2018

asudoh commented Apr 19, 2018

aledavila commented Apr 20, 2018

aagonzales commented Apr 20, 2018

alisonjoseph commented Apr 20, 2018

aledavila commented Apr 20, 2018

alisonjoseph commented Apr 20, 2018

aledavila commented Apr 25, 2018

alisonjoseph Apr 25, 2018 •

edited

Loading

asudoh left a comment

asudoh Apr 26, 2018

tay-aitken commented Apr 26, 2018

tay-aitken commented Apr 27, 2018 •

edited by aledavila

Loading

aledavila commented May 4, 2018 •

edited

Loading

alisonjoseph left a comment

asudoh left a comment •

edited

Loading

alisonjoseph commented May 17, 2018

asudoh commented May 18, 2018

alisonjoseph left a comment •

edited

Loading

tw15egan left a comment

tw15egan May 18, 2018

tw15egan May 18, 2018

tw15egan May 18, 2018

tw15egan May 18, 2018

aledavila commented May 21, 2018

alisonjoseph May 22, 2018

alisonjoseph May 22, 2018

alisonjoseph left a comment

feat(tooltip): add definition tooltip #714

feat(tooltip): add definition tooltip #714

Conversation

aledavila commented Apr 19, 2018 • edited Loading

Overview

Added

Removed

Changed

Notes

alisonjoseph commented Apr 19, 2018

aledavila commented Apr 19, 2018

aledavila commented Apr 19, 2018

alisonjoseph left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aledavila commented Apr 19, 2018

asudoh commented Apr 19, 2018

aledavila commented Apr 20, 2018

aagonzales commented Apr 20, 2018

alisonjoseph commented Apr 20, 2018

aledavila commented Apr 20, 2018

alisonjoseph commented Apr 20, 2018

aledavila commented Apr 25, 2018

alisonjoseph Apr 25, 2018 • edited Loading

Choose a reason for hiding this comment

asudoh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tay-aitken commented Apr 26, 2018

tay-aitken commented Apr 27, 2018 • edited by aledavila Loading

Fixes

aledavila commented May 4, 2018 • edited Loading

alisonjoseph left a comment

Choose a reason for hiding this comment

asudoh left a comment • edited Loading

Choose a reason for hiding this comment

alisonjoseph commented May 17, 2018

asudoh commented May 18, 2018

alisonjoseph left a comment • edited Loading

Choose a reason for hiding this comment

tw15egan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aledavila commented May 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alisonjoseph left a comment

Choose a reason for hiding this comment

aledavila commented Apr 19, 2018 •

edited

Loading

alisonjoseph Apr 25, 2018 •

edited

Loading

tay-aitken commented Apr 27, 2018 •

edited by aledavila

Loading

aledavila commented May 4, 2018 •

edited

Loading

asudoh left a comment •

edited

Loading

alisonjoseph left a comment •

edited

Loading