feat(DatePicker): add flatpickr allowInput passthrough #7037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit c8bcbc0 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit c8bcbc0 https://deploy-preview-7037--carbon-components-react.netlify.app |
joshblack
approved these changes
Oct 13, 2020
dakahn
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7007
This PR allows the user to disable
allowInputon the flatpickr instance since we enable it by default. Since we do not support all of flatpickr's configurable options I opted to add this one prop rather than allowing aflatpickrOptionsconfig objectChangelog
New
allowInputprop for controlling flatpickr, defaults totrueChanged
Testing / Reviewing
Pass in a value for the
allowInputprop and verify that it works as expected (user is or isn't able to type into the flatpickr input field). Since flatpickr is instantiated on mount, I did not create a storybook knob for this