Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breadcrumb): fix breadcrumb on smaller screens #697

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

rezak-otmani
Copy link
Contributor

@rezak-otmani rezak-otmani commented Apr 11, 2018

Overview

solve part of https://github.com/carbon-design-system/carbon-components-react/issues/608
Put the property display: none to display: inline so that breadcrumb switching into a liste instead disappear on smaller screens.

Added

Removed

Changed

Testing / Reviewing

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍 ✅

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @rezak-otmani!

@asudoh asudoh merged commit 2bcf99a into carbon-design-system:master Apr 12, 2018
rezak-otmani added a commit to rezak-otmani/carbon-components that referenced this pull request May 4, 2018
joshblack pushed a commit to joshblack/carbon that referenced this pull request May 2, 2019
…m#697)

This change also moves the focus back to the trigger button when the menu body loses focus.

Refs carbon-design-system#618.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants