Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): stack modal buttons in small viewports #6609

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Aug 4, 2020

Ref #5638

This PR modifies buttons within modals to stack at smaller viewport sizes and include the button separators (depends on #6608). #6608 should be merged in first, but this PR will contain the changes from that PR

Changelog

New

  • modal footer button separators

Changed

  • modal footer button arrangement at smaller viewports

Testing / Reviewing

Confirm the modal footer buttons are styled and arranged correctly at all screen sizes

@netlify
Copy link

netlify bot commented Aug 4, 2020

Deploy preview for carbon-elements ready!

Built with commit 6d24a35

https://deploy-preview-6609--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 4, 2020

Deploy preview for carbon-components-react ready!

Built with commit 6d24a35

https://deploy-preview-6609--carbon-components-react.netlify.app

@emyarod
Copy link
Member Author

emyarod commented Aug 4, 2020

combining with #6608 after UX clarification

@emyarod emyarod closed this Aug 4, 2020
@emyarod emyarod deleted the 5638-stacked-modal-buttons-and-color-contrast branch August 4, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant