Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TableBatchAction): use correct disabled color token #6596

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jul 30, 2020

Closes #6588

This PR updates the text color token for disabled table batch action buttons

Testing / Reviewing

Confirm the disabled table batch action buttons matches the spec (e.g. by adding the disabled attribute to a table batch action button in browser dev tools)

image

@netlify
Copy link

netlify bot commented Jul 30, 2020

Deploy preview for carbon-elements ready!

Built with commit c01ba68

https://deploy-preview-6596--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 30, 2020

Deploy preview for carbon-components-react ready!

Built with commit c01ba68

https://deploy-preview-6596--carbon-components-react.netlify.app

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emyarod looks good!

@emyarod emyarod force-pushed the 6588-disabled-batch-actions-button-visuals branch from 46514e3 to c01ba68 Compare August 6, 2020 17:13
@kodiakhq kodiakhq bot merged commit 5b586a5 into carbon-design-system:master Aug 6, 2020
@emyarod emyarod deleted the 6588-disabled-batch-actions-button-visuals branch August 7, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataTable]: Disabled batch action buttons are visually too prominent
4 participants