Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): change aria-describedby a11y #5957

Conversation

FrivalszkyP
Copy link
Contributor

@FrivalszkyP FrivalszkyP commented Apr 28, 2020

Closes #5959

I tested the Tooltip element with VoiceOver on MacOS and couldn't get it to announce the contents of the tooltip upon focusing on the triggering button element.

Changelog

Changed

  • I moved the tooltipId to the element that has the role="dialog" attribute. That seems to fix the issue with VoiceOver

Testing / Reviewing

Open the Storybook and fire up VoiceIver to test it.

Important information: I tested the Tooltip component with NVDA on Windows and couldn't get it to work either way. I think there are further, more deep-rooted A11Y issues with Tooltip but PR #5489 seems to address those.

@FrivalszkyP FrivalszkyP requested a review from a team as a code owner April 28, 2020 16:21
@ghost ghost requested review from aledavila and tw15egan April 28, 2020 16:22
@aledavila aledavila requested a review from dakahn April 28, 2020 16:29
@netlify
Copy link

netlify bot commented Apr 28, 2020

Deploy preview for carbon-elements ready!

Built with commit 7597cde

https://deploy-preview-5957--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 28, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 7597cde

https://deploy-preview-5957--carbon-components-react.netlify.app

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed VoiceOver is now working as expected ✅ 👍

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing this issue in Safari, and Firefox latest. It does appear to solve the problem on Chrome though. Was this fix Chrome specific?

@dakahn
Copy link
Contributor

dakahn commented Apr 29, 2020

Cross checking results with this work-in-progress WAI-Aria example. The interaction differs, but the tooltip text is readable on button focus and if the user moves reading cursor into the dialog.

@FrivalszkyP
Copy link
Contributor Author

@dakahn you are very right, it seems like it's still not working in Safari. Based on this, the issue is more deeply rooted than I initially thought. For example, the tooltip popup should be reachable by the reading cursor, but right now it closes immediately if I try to move the cursor.

I'm looking into finding a fix but I fear that whatever I do, it'll just introduce conflicts for the eventual merging of #5489. So I think we should close this PR and look for a more all-encompassing solution. I'm keeping an eye on #5489 and see if I can contribute to that discussion instead of doing anything parallel to that.

@aledavila
Copy link
Contributor

Thanks yes we realized tooltip is quite a big issue for us. Keep an eye out. Will close for now.

@aledavila aledavila closed this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Tooltip text is not announced by VoiceOver upon focusing on the triggering element
4 participants