-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tooltip): change aria-describedby a11y #5957
fix(tooltip): change aria-describedby a11y #5957
Conversation
Deploy preview for carbon-elements ready! Built with commit 7597cde |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 7597cde https://deploy-preview-5957--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed VoiceOver is now working as expected ✅ 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still seeing this issue in Safari, and Firefox latest. It does appear to solve the problem on Chrome though. Was this fix Chrome specific?
Cross checking results with this work-in-progress WAI-Aria example. The interaction differs, but the tooltip text is readable on button focus and if the user moves reading cursor into the dialog. |
@dakahn you are very right, it seems like it's still not working in Safari. Based on this, the issue is more deeply rooted than I initially thought. For example, the tooltip popup should be reachable by the reading cursor, but right now it closes immediately if I try to move the cursor. I'm looking into finding a fix but I fear that whatever I do, it'll just introduce conflicts for the eventual merging of #5489. So I think we should close this PR and look for a more all-encompassing solution. I'm keeping an eye on #5489 and see if I can contribute to that discussion instead of doing anything parallel to that. |
Thanks yes we realized tooltip is quite a big issue for us. Keep an eye out. Will close for now. |
Closes #5959
I tested the
Tooltip
element with VoiceOver on MacOS and couldn't get it to announce the contents of the tooltip upon focusing on the triggering button element.Changelog
Changed
tooltipId
to the element that has therole="dialog"
attribute. That seems to fix the issue with VoiceOverTesting / Reviewing
Open the Storybook and fire up VoiceIver to test it.
Important information: I tested the
Tooltip
component with NVDA on Windows and couldn't get it to work either way. I think there are further, more deep-rooted A11Y issues withTooltip
but PR #5489 seems to address those.