feat(link): add disabled link #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethsjudd
suggested changes
Feb 14, 2018
src/components/link/link.html
Outdated
| @@ -1 +1,2 @@ | |||
| <a href="#" class="bx--link">Link</a> | |||
| <a href="#" class="bx--link" tabindex="-1" aria-disabled="true" disabled>Link</a> | |||
There was a problem hiding this comment.
disabled is not a valid attribute for an <a> element, only aria-disabled should be used.
There was a problem hiding this comment.
Ah right, was just using it to target it via css, but figured I can use &[aria-disabled="true"] instead
elizabethsjudd
approved these changes
Feb 14, 2018
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
…arbon-design-system#597) * fix(NumberInput): cope with user events being referred in async code Fixes carbon-design-system#566. * fix(NumberInput): set <input> as an imaginary target of events being fired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled Links
We were surfacing
disabledlinks on our website, but didn't actually have anything defined in code. Added styles as well as a11y suggestions from @elizabethsjudd