chore(devenv): remove JS build from dev server prereq #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asudoh
changed the title
As dev server code (server.js) itself runs WebPack to build JS code. Also changed the route of dev env's static content so that WebPack dev middleware can handle the route.
asudoh
force-pushed
the
js-build-server
branch
from
8968601
to
8ccf2b5
Compare
asudoh
requested review from
alisonjoseph,
joshblack,
marijohannessen and
tw15egan
asudoh
changed the title
alisonjoseph
approved these changes
Feb 14, 2018
|
👍 ✅ It worked for me just doing |
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
* refactor(detail-page-header): start work on refactoring * refactor(detail-page-header): refactor detail page header for 3.x * test(detail-page-header): start updating tests: * refactor(detail-page-header): add scroll styles * fix(detail-page-header): debounce scroll * fix(detail-page-header): fix logic, add eslint ignore * refactor(detail-page-header): add status node, scrolling props * test(detail-page-header): update tests * fix(detail-page-header): allow users to pass down scroll props * refactor(detail-page-header): update storybook prop names
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
* fix: bug fixes for carbon-design-system#508 * fix: made change suggested in comment, and fixed unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change removes JS build that used to run before our dev server runs, as our dev server code (server.js) itself runs WebPack to build JS code.
Changed
Changed the route of dev env's static content so that WebPack dev middleware can handle the route.
Testing / Reviewing
Testing should make sure our dev env is not broken.