feat(icons): add icons for covariate and factor #5271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements failed. Built with commit 6ece94a https://app.netlify.com/sites/carbon-elements/deploys/5e3c81a7b969740008d49c86 |
|
Deploy preview for carbon-components-react failed. Built with commit 6ece94a https://app.netlify.com/sites/carbon-components-react/deploys/5e3c81a7f75cfb0009c33b9b |
|
@janhassel do you know if these were approved/made by conrad? |
|
No, we haven't run those by Conrad yet. |
|
@laurenmrice icons are not approved. Will include the updated icons in a PR with the next batch of icons I add to the repo next week. |
dakahn
approved these changes
Feb 6, 2020
|
Closing this PR as it sounds as if @conradennis will add this in a separate PR once approved. |
|
PR including |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add data type icons for covariate and factor.
Changelog
New
Testing / Reviewing
packages/iconsyarn developin/packages/icons/examples/preview