Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): remove layer import #5160

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

tw15egan
Copy link
Member

Removes an import that was causing build failures.

Changelog

Removed

  • layer.scss import in the storybook environment

Testing / Reviewing

Ensure storybook compiles

@tw15egan tw15egan requested a review from a team as a code owner January 23, 2020 20:45
@ghost ghost requested review from aledavila and emyarod January 23, 2020 20:45
@netlify
Copy link

netlify bot commented Jan 23, 2020

Deploy preview for the-carbon-components ready!

Built with commit 113ceb4

https://deploy-preview-5160--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 23, 2020

Deploy preview for carbon-elements ready!

Built with commit 113ceb4

https://deploy-preview-5160--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 23, 2020

Deploy preview for carbon-components-react ready!

Built with commit 113ceb4

https://deploy-preview-5160--carbon-components-react.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @tw15egan!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, this is slightly related to #5126 right?

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also should we update migrate-to-10.x.md?

@tw15egan
Copy link
Member Author

@emyarod added! Good idea.

@tw15egan tw15egan merged commit e3b3f0e into carbon-design-system:master Jan 24, 2020
@tw15egan tw15egan deleted the storybook-layer branch January 24, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants