feat(progress-indicator): adds hidden span to announce state of completion #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
asudoh
reviewed
Jan 21, 2020
| @@ -70,16 +70,31 @@ export const ProgressStep = ({ ...props }) => { | |||
| ); | |||
| }; | |||
|
|
|||
| let message = 'Incomplete'; | |||
There was a problem hiding this comment.
g11n; Do we want to add a prop to let app specify the assistive text? (Though translate-ability for assistive text didn't use to be a hard-requirements, I have seen several issues asking for it)
There was a problem hiding this comment.
Good idea! I added it, it's the first time I've done it so let me know if it all looks good!
|
Deploy preview for carbon-elements ready! Built with commit b0fd7f4 |
|
Deploy preview for carbon-components-react failed. Built with commit b0fd7f4 https://app.netlify.com/sites/carbon-components-react/deploys/5e2b167e53a5c7000933b3a7 |
|
Deploy preview for the-carbon-components ready! Built with commit b0fd7f4 https://deploy-preview-5125--the-carbon-components.netlify.com |
joshblack
approved these changes
Jan 22, 2020
abbeyhrt
changed the title
tw15egan
added
status: waiting for reviewer's response 💬
and removed
status: ready to merge 🎉
labels
asudoh
added
status: ready to merge 🎉
and removed
status: waiting for reviewer's response 💬
labels
This was referenced Feb 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4246
This PR adds a hidden span that will announce the state of the step, "Complete", "current", or "invalid" for screenreaders.
Changelog
New
spanannouncing step completionChanged
divwithrole="button"to abuttonelementrole="button"Testing / Reviewing
Using whatever screenreader you prefer to test the component and ensure that the completion state is announced.