fix(TableToolbarSearch): allow default values to be set #5089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
2 tasks
tw15egan
changed the title
|
Deploy preview for the-carbon-components ready! Built with commit abb08ec https://deploy-preview-5089--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react failed. Built with commit abb08ec https://app.netlify.com/sites/carbon-components-react/deploys/5e2b627e74fb1f0008826468 |
|
Deploy preview for carbon-elements ready! Built with commit abb08ec |
tw15egan
force-pushed
the
table-toolbar-search-value-fix
branch
from
1cd2e5d
to
baca15e
Compare
joshblack
suggested changes
Jan 20, 2020
…carbon-components into table-toolbar-search-value-fix
|
@joshblack updated |
joshblack
reviewed
Jan 22, 2020
|
@joshblack are we good with this? |
…carbon-components into table-toolbar-search-value-fix
joshblack
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3170
The
DefaultValueprop was being ignored. This checks for the presence of aDefaultValue, and if it exists, it is used as the default state ofvalue. On the initial load, it sets the expanded state totrueand runs theonChangePropto filter the table. Modified thehandleOnInputValueChangeinDataTable.jsto account for non-event based sorting (table loads with a default value).Changelog
New
DefaultValueprop works as intendedChanged
handleOnInputValueChangenow has adefaultValueparameterRemoved
DefaultValuebeing passed directly down toSearch. IfDefaultValueexists, it is immediately set tovaluewhich is then passed down.Testing / Reviewing
src/components/DataTable/stories/with-toolbar.jsdefaultValue="1"toTableToolbarSearchWith ToolbarStorybook example, verify only 1 result shows up.